style: improve Kotlin code #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some comments that describe the changes
kkafar
force-pushed
the
@kkafar/improve-kotlin
branch
from
de41f4d
to
6011a75
Compare
kkafar
requested review from
kacperkapusciak and
WoLewicki
and removed request for
kacperkapusciak
WoLewicki
approved these changes
Aug 16, 2022
j-piasecki
reviewed
Aug 19, 2022
android/src/main/java/com/swmansion/rnscreens/ScreenContainer.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackViewManager.kt
Outdated
Show resolved
Hide resolved
Merge branch 'main' into @kkafar/improve-kotlin
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve Kotlin style in library's codebase.
Changes
Many syntax related changes, including:
Test code and steps to reproduce
Run any of the example applications and see that no behaviour is changed.
Checklist