v16.1.1 #1464
v16.1.1 #1464
Conversation
Typo in README example code
Handling reconnect scenarios properly when socket is hung
fix never running timingOut due to weak self capture
|
@WestFlow127 LMK how testing goes |
@nuclearace , I pulled the repo, switch to this PR, and ran all tests in |
|
@WestFlow127, if you're able, testing against a socket.io server and doing some basic sanity checks would be helpful |
|
@nuclearace I can do that, we run a socket.io server at my company. I'll test general functionality, various reconnection scenarios, and the timingOut fix. |
Update:Was able to test general functionality which was good. Testing various reconnects was difficult due to my locations poor 5G service. I want to test on stable/good connections. Will likely do so over the holiday. (@nuclearace ) |
|
I can see that this version fixes the issue i just reported on #1470 |
|
Any ETA for this release? |
|
I have the green light to resume testing this PR during my workday tomorrow. |
|
Just finished testing 5G/cellular reconnects and it worked great. |
|
More users of this repo are requesting this to be merged: #1375 (comment) @nuclearace I support merging this as I have tested it against our socket server. |
Can we get it in? Would solve a big issue we're facing! 🙏🏼 // @nuclearace |
|
@nuclearace Please read above comments 🙏🏼 |
Currently there is an error when compiling for release: ``` Compiling for iOS 11.0, but module 'Starscream' has a minimum deployment target of iOS 12.0 ``` This pull request addresses this error by bumping the minimum deployment target to match Starscream.
Bump minimum deployment target to iOS 12 to match Starscream dependency
|
@nuclearace any updates on the socket.io for swift? This library feels deprecated and it's the only package I've come accross in the socket.io ecosystem that is no longer maintained/working properly. |
We have the same question. Both on the server and on Android everything seems to work fine, but on iOS we're constantly battling issues due to the unreliability of this SDK. This PR made it somewhat better, but still seems that there's a ton of room for improvement - yet there doesn't seem to be any active development. |
|
for us and many other people, the swift client doesn't connect in WS mode, only in polling. using latest nodeJS backend and android works flawless. sadly this is not the case with swift. |
Sorry about this, life has sadly been quite rough this past year and I haven't been able to devote much spare time outside of work and family. I'm hoping to start circle back in the coming months |
Looking into this now |
|
@nuclearace Things to add to this version:
|
|
when is this v16.1.1 going to release ? |
Fixes for various connection status stuff