Update Starscream to v4.0.8 #1487
Conversation
|
when will this get released? its needed to remove apple warnings. |
|
With the privacy manifest deadline looming, if there isn't a new release that merges these changes for the Starscream dependency and you're using SPM, it looks like it might(?) be possible to fix this by bringing in the Socket.IO client as a local package and then editing the package.swift file to specify Starscream 4.0.8 instead of 4.0.6. I'm basing this assumption on https://developer.apple.com/documentation/xcode/editing-a-package-dependency-as-a-local-package. Has anyone tried this? |
|
|
|
This really does need to be updated because you've specified |
|
@nuclearace this should be added to v16.1.1 |
|
is there anyone who can approve this PR? 'o'? |
| @@ -8,7 +8,7 @@ let package = Package( | |||
| .library(name: "SocketIO", targets: ["SocketIO"]) | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/daltoniam/Starscream", .exactItem("4.0.6")), | |||
| .package(url: "https://github.com/daltoniam/Starscream", .exactItem("4.0.8")), | |||
There was a problem hiding this comment.
I also believe that's the way to go. However, since I don't fully understand the intentions behind the changes made in 3c81d0e , I feel it's not appropriate for me to do it. thx.
|
any updates on this? |
|
The deadline requiring privacy manifests has now past and expecting releases including socket-io to get blocked by apple unless this is done. Any update on when this will be merged and deployed? |
ref #1478
We need to update the version of Starscream to support the Privacy Manifest.
daltoniam/Starscream@4.0.6...4.0.8
This pull request is a redo of #1486.
I have reconfirmed the operation, and it appears to be functioning correctly in my application( socket.io 2 servers ).