Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/azure credentials helper #1274

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Conversation

ivanstanev
Copy link
Contributor

@ivanstanev ivanstanev commented Feb 28, 2023

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

Support Azure Workload Identity and using the ACR credentials helper

Notes for the reviewer

Resolves #1223

May need to wait for #1269

Ensures that the Azure Container Registry credentials helper can read the environment variables and authenticate with the registry.
@ivanstanev ivanstanev self-assigned this Feb 28, 2023
@ivanstanev ivanstanev requested a review from a team as a code owner February 28, 2023 15:06
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Expected release notes (by @ivanstanev)

fixes:
allow configuring ServiceAccount labels for Azure Workload Identity (5b3afb1)
pass Azure environment variables when executing skopeo (1da4cf3)
lockfile to version 2 (ea2d4f8)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@Tolsto
Copy link

Tolsto commented Feb 28, 2023

I tested this PR with chrismellard/docker-credential-acr-env#13. Works.

Copy link
Contributor

@minsiyang minsiyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

@ivanstanev ivanstanev merged commit fcbff4a into staging Mar 1, 2023
@ivanstanev ivanstanev deleted the fix/azure-credentials-helper branch March 1, 2023 08:10
@snyk-deployer
Copy link
Collaborator

🎉 This PR is included in version 2.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kat1906 pushed a commit that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🙏] Support for ACR authentication via Azure Workload Identity
4 participants