Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go install latest docker-credential-acr-env #1269

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

snaftaly
Copy link
Contributor

@snaftaly snaftaly commented Feb 19, 2023

  • Tests written and linted ℹ︎
  • Documentation written ℹ︎
  • Commit history is tidy ℹ︎

What this does

go install latest docker-credential-acr-env in image

Notes for the reviewer

Previous version of docker-credential-acr-env had vulnerable dependencies which were solved in the latest version. Therefore we can now use the latest version in our image. Using a pinned version in case 'latest' tag has a breaking change.

Previous version of docker-credential-acr-env had vulnerable
dependencies which were solved in an updated version. Therefore
we can now use this version in our image.
@snaftaly snaftaly force-pushed the chore/go-install-docker-credential-acr-env branch from 8155411 to f7450ba Compare February 28, 2023 08:46
@snaftaly snaftaly marked this pull request as ready for review February 28, 2023 13:24
@snaftaly snaftaly requested a review from a team as a code owner February 28, 2023 13:24
@ivanstanev ivanstanev mentioned this pull request Feb 28, 2023
3 tasks
@Tolsto
Copy link

Tolsto commented Mar 6, 2023

FYI, chrismellard/docker-credential-acr-env#13 has been merged.

@snaftaly snaftaly merged commit 73bc044 into staging Mar 14, 2023
@snaftaly snaftaly deleted the chore/go-install-docker-credential-acr-env branch March 14, 2023 08:26
@Tolsto
Copy link

Tolsto commented Mar 14, 2023

@snaftaly docker-credential-acr-env@fb789970a885098fb386e1d938499d9eb9449821 doesn't contain the code that is required for #1274 to work properly. chrismellard/docker-credential-acr-env@82a0ddb would be needed.

@snyk-deployer
Copy link
Collaborator

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants