Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix return value of nagle_enable #642

Merged
merged 1 commit into from Jul 25, 2022
Merged

fix return value of nagle_enable #642

merged 1 commit into from Jul 25, 2022

Conversation

stlankes
Copy link
Contributor

The old implementation returns the wrong value (ACK delay duration) and doesn't describe if the Nagle algorithm is enabled or not.

@stlankes
fix return value of nagle_enable
8090469 
The old implementation returns the wrong value (ACK delay duration)
and doesn't describe if the Nagle algorithm is enabled or not.
@Dirbaio
Copy link
Member

Dirbaio commented Jul 25, 2022

Thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 25, 2022

Build succeeded:

@bors bors bot merged commit 4db073f into smoltcp-rs:master Jul 25, 2022
@stlankes stlankes mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stlankes @Dirbaio