rename function to enable / disable nagle algorithm #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Looks good to me. This function is not used anywhere yet though, right?
We might want to name it sys_tcp_set_nodelay as done in std though. And a corresponding sys_tcp_nodelay as getter might be useful.
You can go ahead an merge this though, I have no strong opinion on this. :)
|
Yes, but a getter function requires a new version of smoltcp (see smoltcp-rs/smoltcp/pull/642). |
|
@mkroening Why does CI fail? Any idea? |
Seems to be quite strange indeed. I think we could disable the windows CI for now. |
|
bors r+ |
You also need to remove the job from |
|
Timed out. |
|
bors r+ |
|
bors r- |
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.