Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin the clap version used to prevent future deprecation warnings #1464

Merged
merged 3 commits into from Jun 14, 2022
Merged

Pin the clap version used to prevent future deprecation warnings #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23dc458
Pin the `clap` version used to prevent future deprecation warnings
jdisanti Jun 13, 2022
216e5a6
Merge remote-tracking branch 'upstream/main' into jdisanti-pin-clap
jdisanti Jun 13, 2022
4acdb1c
Merge branch 'main' into jdisanti-pin-clap
crisidev Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust-runtime/aws-smithy-http-server/examples/pokemon_service/Cargo.toml
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ authors = ["Smithy-rs Server Team <smithy-rs-server@amazon.com>"]
description = "A smithy Rust service to retrieve information about Pokémon."

[dependencies]
clap = { version = "3.2.1", features = ["derive"] }
clap = { version = "~3.2.1", features = ["derive"] }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.

hyper = {version = "0.14", features = ["server"] }
tokio = "1"
tower = "0.4"
Expand Down
100 changes: 50 additions & 50 deletions tools/api-linter/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tools/api-linter/Cargo.toml
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@ publish = false
[dependencies]
anyhow = "1"
cargo_metadata = "0.14"
clap = { version = "3.1", features = ["derive"] }
clap = { version = "~3.1.18", features = ["derive"] }
owo-colors = { version = "3", features = ["supports-colors"] }
pest = "2" # For pretty error formatting
rustdoc-types = "0.10"
Expand Down