Pin the clap version used to prevent future deprecation warnings
#1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
approved these changes
Jun 14, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Jun 14, 2022
epage
reviewed
Jun 15, 2022
| @@ -7,7 +7,7 @@ authors = ["Smithy-rs Server Team <smithy-rs-server@amazon.com>"] | |||
| description = "A smithy Rust service to retrieve information about Pokémon." | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "3.2.1", features = ["derive"] } | |||
| clap = { version = "~3.2.1", features = ["derive"] } | |||
There was a problem hiding this comment.
This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
clapmaintainers are planning to introduce more deprecations with every minor release (clap-rs/clap#3822):Since we're disallowing warnings broadly at the environment variable level, this PR pins all the
clapversions so that future minor releases won't break our CI.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.