New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: color golangci-lint xml with bat #9266
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,9 +88,15 @@ jobs: | |
only-new-issues: ${{ github.event.schedule == '' }} # show only new issues, unless it's a scheduled run | ||
allow-extra-out-format-args: true | ||
args: --out-format checkstyle:golangci-lint-report.xml | ||
- name: Install bat | ||
uses: awalsh128/cache-apt-pkgs-action@1850ee53f6e706525805321a3f2f863dcf73c962 # v1.3.0 | ||
with: | ||
packages: bat | ||
if: always() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we always pass? Seems like we'd want to fix this immediately if we didnt have access to reading reports |
||
- name: Print lint report artifact | ||
if: always() | ||
run: test -f golangci-lint-report.xml && cat golangci-lint-report.xml || true | ||
shell: bash | ||
run: test -f golangci-lint-report.xml && bat -pP golangci-lint-report.xml || true | ||
- name: Store lint report artifact | ||
if: always() | ||
uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much of an improvement does this give us over just reinstalling the package everytime? I'd like to keep our GHA deps low if we can.
Another route would be to install a dockerized version since I'd imagine this image already has docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually gotten it to work yet. IIRC I was just trying different approach of calling
bat
, and had no luck. Feel free to push a new solution.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the stdout format is already colour coded, i'd specify it as an additional output instead. golangci/golangci-lint#2386