.github/workflows: color golangci-lint xml with bat #9266
Conversation
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
jmank88
changed the title
jmank88
force-pushed
the
lint-xml-color
branch
5 times, most recently
from
dd028b5
to
0af7f96
Compare
|
SonarQube Quality Gate
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
SonarQube Quality Gate
|
| @@ -88,9 +88,15 @@ jobs: | |||
| only-new-issues: ${{ github.event.schedule == '' }} # show only new issues, unless it's a scheduled run | |||
| allow-extra-out-format-args: true | |||
| args: --out-format checkstyle:golangci-lint-report.xml | |||
| - name: Install bat | |||
| uses: awalsh128/cache-apt-pkgs-action@1850ee53f6e706525805321a3f2f863dcf73c962 # v1.3.0 | |||
There was a problem hiding this comment.
How much of an improvement does this give us over just reinstalling the package everytime? I'd like to keep our GHA deps low if we can.
Another route would be to install a dockerized version since I'd imagine this image already has docker
There was a problem hiding this comment.
I haven't actually gotten it to work yet. IIRC I was just trying different approach of calling bat, and had no luck. Feel free to push a new solution.
bat: command not found
There was a problem hiding this comment.
If the stdout format is already colour coded, i'd specify it as an additional output instead. golangci/golangci-lint#2386
| uses: awalsh128/cache-apt-pkgs-action@1850ee53f6e706525805321a3f2f863dcf73c962 # v1.3.0 | ||
| with: | ||
| packages: bat | ||
| if: always() |
There was a problem hiding this comment.
Should we always pass? Seems like we'd want to fix this immediately if we didnt have access to reading reports
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
No description provided.