Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UniRepeat#until javadoc #676

Merged
merged 1 commit into from Sep 8, 2021
Merged

Conversation

gwenneg
Copy link
Contributor

@gwenneg gwenneg commented Sep 8, 2021

Unless I misunderstood something, the Javadoc should contain this.

@cescoffier
Copy link
Contributor

Thanks, great catch!

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #676 (9c1c310) into main (b7680b3) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #676      +/-   ##
============================================
+ Coverage     90.07%   90.24%   +0.16%     
- Complexity     2986     2991       +5     
============================================
  Files           374      374              
  Lines         11764    11764              
  Branches       1476     1478       +2     
============================================
+ Hits          10597    10616      +19     
+ Misses          595      590       -5     
+ Partials        572      558      -14     
Impacted Files Coverage Δ
...main/java/io/smallrye/mutiny/groups/UniRepeat.java 100.00% <ø> (ø)
...ava/io/smallrye/mutiny/helpers/HalfSerializer.java 77.77% <0.00%> (-11.12%) ⬇️
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 82.22% <0.00%> (-8.89%) ⬇️
...mallrye/mutiny/helpers/queues/MpscLinkedQueue.java 90.32% <0.00%> (-8.07%) ⬇️
...subscription/SwitchableSubscriptionSubscriber.java 95.08% <0.00%> (-2.46%) ⬇️
...smallrye/mutiny/helpers/test/AssertSubscriber.java 90.22% <0.00%> (-1.51%) ⬇️
...mallrye/mutiny/operators/multi/MultiGroupByOp.java 83.70% <0.00%> (+0.88%) ⬆️
...lrye/mutiny/subscription/SerializedSubscriber.java 83.01% <0.00%> (+0.94%) ⬆️
...smallrye/mutiny/operators/multi/MultiEmitOnOp.java 90.47% <0.00%> (+0.95%) ⬆️
...a/io/smallrye/mutiny/helpers/BlockingIterable.java 89.79% <0.00%> (+1.02%) ⬆️
... and 9 more

@jponge jponge added this to the 1.1.0 milestone Sep 8, 2021
@jponge jponge merged commit 36c5c3b into smallrye:main Sep 8, 2021
@jponge
Copy link
Member

jponge commented Sep 8, 2021

Thanks @gwenneg

@gwenneg gwenneg deleted the unirepeat-javadoc branch September 8, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants