Prevent unnecessary RBAC users request #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenneg
commented
Sep 8, 2021
Comment on lines
+123
to
+124
| quarkus.cache.caffeine.rbac-recipient-users-provider-get-users.expire-after-write=PT10M | ||
| quarkus.cache.caffeine.rbac-recipient-users-provider-get-group-users.expire-after-write=PT10M |
There was a problem hiding this comment.
As suggested by @pilhuhn on Slack yesterday.
Prod is currently caching data for 1 minute (the 5 minute increase hasn't been deployed).
gwenneg
force-pushed
the
rbac-optimization
branch
from
52d32c4
to
bffc224
Compare
gwenneg
commented
Sep 8, 2021
| @@ -119,7 +119,7 @@ public void initCounters() { | |||
| AtomicInteger::new, | |||
| state -> fetcher.apply(state.getAndIncrement()) | |||
| ) | |||
| .until(page -> page.getData().isEmpty()) | |||
| .whilst(page -> page.getData().size() == rbacElementsPerPage) | |||
There was a problem hiding this comment.
Most of the time, this will prevent one RBAC request per recipients resolution.
See this for details about until and whilst.
There was a problem hiding this comment.
There's an error in the Javadoc BTW: until stops when the predicates passes (the Javadoc says the opposite).
There was a problem hiding this comment.
From reading the Javadoc, whilst() is really what we want.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.