Skip to content

Add include_num_members support to conversation.info request #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 16, 2022
Merged

Add include_num_members support to conversation.info request #989

merged 7 commits into from
Dec 16, 2022
+42 −7

Conversation

Yohan460
Copy link
Contributor

Add include_num_members support to conversation.info request

@johanmcgwire-cb
Add include_num_members support to conversation.info request

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: B2C9CC93F362E9A8
Learn about vigilant mode
2bb1377
@johanmcgwire-cb
Fix test

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: B2C9CC93F362E9A8
Learn about vigilant mode
094f096
@Yohan460
Copy link
Contributor Author

Hey @kanata2 👋

Out of curiosity, is there any cadence for releases here? Would really love to get this merged in to resolve a dependency we have.

Many Thanks,

Johan

@kanata2
Copy link
Member

kanata2 commented Oct 29, 2021

@Yohan460
Thanks for submitting PR!
This PR has backward-incompatibility changes.
So we'll release this in the next minor version(= v.10.0) if approved.

kanata2
kanata2 reviewed Nov 6, 2021
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yohan460
I've commented again.
(By the way, the commit seems to be unverified, so please just check)

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Nov 6, 2021
@Yohan460
Copy link
Contributor Author

Updated the GPG key signing, haven't done pubilc PRs for a long time. The most recent commit should go verified eventually

@Yohan460
Swap to struct input

Verified

This commit was signed with the committer’s verified signature.
Yohan460 Johan McGwire
GPG key ID: 619C891B6B47AC06
Verified
Learn about vigilant mode
e4955fd 
Signed-off-by: Johan McGwire <johan@mcgwire.tech>
@Yohan460 Yohan460 force-pushed the include_num_members-support branch from 122cb48 to e4955fd Compare November 26, 2021 14:13
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Dec 9, 2021
@kanata2
Copy link
Member

kanata2 commented Jan 9, 2022

@Yohan460 It seems that the lint phase in CI failed, so please confirm it.

@kanata2 kanata2 added the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jan 9, 2022
@Yohan460
Copy link
Contributor Author

Yohan460 commented Feb 9, 2022

@kanata2 The lint failure is un-related to my changes and appears to be due to a failure in the CI/CD pipeline. If you could take a look it would be appreciated

@kanata2
Copy link
Member

kanata2 commented Feb 12, 2022 •
edited
Loading

Could you run gofmt -w conversation.go?

@Yohan460
gofmt

Verified

This commit was signed with the committer’s verified signature.
Yohan460 Johan McGwire
GPG key ID: 619C891B6B47AC06
Verified
Learn about vigilant mode
fd9eee8
@Yohan460
Copy link
Contributor Author

done, could you re-trigger CI for me?

@zchee zchee requested review from kanata2 and zchee February 26, 2022 10:55
@zchee zchee added needs review and removed feedback given When a review has been conducted and awaiting the response from the comitter(s) labels Feb 26, 2022
@zchee
Copy link
Contributor

zchee commented Feb 26, 2022

@Yohan460 Hi, this is newer slack-go maintainer.

I'll review this pull request later. Thanks for contribution.

@Yohan460
Copy link
Contributor Author

bumping this @zchee @kanata2 🥺 🙏

kanata2
kanata2 reviewed Apr 16, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay. I plan to release this in v0.11.

@kanata2 kanata2 added feedback given When a review has been conducted and awaiting the response from the comitter(s) and removed needs review labels Apr 16, 2022
@Yohan460
Return errors upon missing parameters

Verified

This commit was signed with the committer’s verified signature.
Yohan460 Johan McGwire
GPG key ID: 619C891B6B47AC06
Verified
Learn about vigilant mode
439edc3
@Yohan460 Yohan460 requested a review from kanata2 May 2, 2022 23:30
kanata2
kanata2 requested changes May 3, 2022
View reviewed changes
@Yohan460
Use built-in errors package

Verified

This commit was signed with the committer’s verified signature.
Yohan460 Johan McGwire
GPG key ID: 619C891B6B47AC06
Verified
Learn about vigilant mode
6ee76f4
@Yohan460 Yohan460 requested a review from kanata2 May 3, 2022 14:38
kanata2
kanata2 approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kanata2
kanata2 requested changes May 3, 2022
View reviewed changes
@Yohan460
combine tests to handle http handler registration

Verified

This commit was signed with the committer’s verified signature.
Yohan460 Johan McGwire
GPG key ID: 5730EAE892494BAA
Verified
Learn about vigilant mode
ba92d34
@Yohan460 Yohan460 force-pushed the include_num_members-support branch from 80f904b to ba92d34 Compare May 8, 2022 20:35
@Yohan460 Yohan460 requested a review from kanata2 May 8, 2022 20:38
@kanata2 kanata2 mentioned this pull request Jul 21, 2022
Closed
kanata2
kanata2 approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to release this in v0.12

@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label Jul 21, 2022
@kanata2 kanata2 added this to the v0.12.0 milestone Jul 21, 2022
@kanata2 kanata2 merged commit 617bdc1 into slack-go:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2

@zchee zchee

Assignees
No one assigned
Labels
breaking changes enhancement
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Yohan460 @kanata2 @zchee @johanmcgwire-cb