Add include_num_members option to GetConversationInfo #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanata2
reviewed
Jul 21, 2022
kanata2
added
the
feedback given
|
Also, this PR is dup of #989, so close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes
This changes GetConversationInfo to add a second boolean to support the include_num_members field. This could be resolved similarly by creating a new method like GetConversationInfoWithMemberInfo, but otherwise resolving this missing field more generally would require a more structural change (a way of supporting arbitrary fields, which would require a more significant change to the API generally)
Since the existing tests did no specific testing for include_locale, I didn't add one for include_num_members, though I did update the test to compile/run successfully.