Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field to inputblock #970

Merged
merged 3 commits into from Jun 2, 2022
Merged

Conversation

deto-r
Copy link
Contributor

@deto-r deto-r commented Sep 7, 2021

In this PR, I responded to this issue.#964
With this change, the NewInputBlock function has one more argument.

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This PR will be released in v0.10.0

@kanata2 kanata2 added this to the v0.10.0 milestone Sep 16, 2021
@kanata2 kanata2 linked an issue Sep 21, 2021 that may be closed by this pull request
@kanata2
Copy link
Member

kanata2 commented Nov 14, 2021

Sorry, please let me postpone the release of this PR to v0.11.0, because I want to release other bugfix in a hurry...

@deto-r
Copy link
Contributor Author

deto-r commented Nov 15, 2021

It's ok. 🙆‍♂️

@chrisgoffinet
Copy link

can this be marked for next release?

@kanata2 kanata2 merged commit b2bdf74 into slack-go:master Jun 2, 2022
@deto-r deto-r deleted the add_field_to_inputblock branch June 3, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About the lack of a Hint field in NewInputBlock function
3 participants