Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the lack of a Hint field in NewInputBlock function #964

Closed
deto-r opened this issue Aug 18, 2021 · 2 comments · Fixed by #970
Closed

About the lack of a Hint field in NewInputBlock function #964

deto-r opened this issue Aug 18, 2021 · 2 comments · Fixed by #970

Comments

@deto-r
Copy link
Contributor

deto-r commented Aug 18, 2021

Is there any reason why the NewInputBlock doesn't have a Hint field?

func NewInputBlock(blockID string, label *TextBlockObject, element BlockElement) *InputBlock {
	return &InputBlock{
		Type:    MBTInput,
		BlockID: blockID,
		Label:   label,
		Element: element,
	}
}

If not, I will send a PR.

@kanata2
Copy link
Member

kanata2 commented Sep 7, 2021

Probably not particularly. (Maybe it was added later.)

If not, I will send a PR.

👍

@deto-r
Copy link
Contributor Author

deto-r commented Sep 7, 2021

Hi,Thanks for the reply.
I've sent out a PR, please check it out.

@kanata2 kanata2 linked a pull request Sep 21, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants