Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose is_enterprise_install field #1255

Merged
merged 1 commit into from Feb 10, 2024

Conversation

7ail
Copy link
Contributor

@7ail 7ail commented Feb 1, 2024

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.

Just exposing an existing field within the InteractionCallback object returned from Slack.

@7ail
Copy link
Contributor Author

7ail commented Feb 1, 2024

@parsley42 👋🏻 Hey, can I get this reviewed and merged please. Thanks.

Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial

@parsley42 parsley42 merged commit 4c9f181 into slack-go:master Feb 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants