Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mistakes in propTypes #2911

Merged
merged 10 commits into from Jul 11, 2022
Merged

fix: mistakes in propTypes #2911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9532a8d
fix(propTypes): oneOf -> oneOfType
JackUait Jun 10, 2022
688c767
fix: replace propTypes.node with ComponentType
JackUait Jun 12, 2022
47f5372
Merge branch 'master' of https://github.com/skbkontur/retail-ui into …
JackUait Jun 12, 2022
1b01051
chore(review): replace Element with HTMLElment
JackUait Jun 26, 2022
5fa5b6e
Merge branch 'master' of https://github.com/skbkontur/retail-ui into …
JackUait Jun 26, 2022
1230baa
chore(ComponentType): expand type with bool
JackUait Jun 26, 2022
cb3840c
Merge branch 'master' of https://github.com/skbkontur/retail-ui into …
JackUait Jun 29, 2022
bcdc743
refactor(ComponentType): rename ComponentType and reduct its influence
JackUait Jun 29, 2022
b915d45
chore(review): abandon ReactNodePropTypes type
JackUait Jun 29, 2022
2f153c6
Merge branch 'master' into fix/one-of-prop-types
lossir Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-ui/components/Textarea/TextareaCounter.tsx
View file
Open in desktop
Expand Up @@ -65,8 +65,8 @@ export const TextareaCounter = forwardRefAndName<TextareaCounterRef, TextareaCou

TextareaCounter.propTypes = {
length: propTypes.number.isRequired,
value: propTypes.oneOf([propTypes.string, propTypes.number]),
help: propTypes.oneOf([propTypes.node, propTypes.func]),
value: propTypes.oneOfType([propTypes.string, propTypes.number]),
help: propTypes.oneOfType([propTypes.node, propTypes.func]),
onCloseHelp: propTypes.func.isRequired,
textarea: propTypes.node.isRequired,
lossir marked this conversation as resolved.
Show resolved Hide resolved
};
2 changes: 1 addition & 1 deletion packages/react-ui/internal/icons/16px/index.tsx
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ const SvgIcon = forwardRefAndName<HTMLElement, SvgIconProps>(

SvgIcon.propTypes = {
color: propTypes.string,
size: propTypes.oneOf([propTypes.string, propTypes.number]),
size: propTypes.oneOfType([propTypes.string, propTypes.number]),
style: propTypes.object,
children: propTypes.node,
};
Expand Down