Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mistakes in propTypes #2911

Merged
merged 10 commits into from Jul 11, 2022
Merged

fix: mistakes in propTypes #2911

merged 10 commits into from Jul 11, 2022

Conversation

JackUait
Copy link
Contributor

@JackUait JackUait commented Jun 10, 2022 •
edited

fixes IF-509

Во время добавления линтинга для React'а использовал неправильный мэтчер, из-за чего в консоль начал падать ворнинг:

Warning:
Failed prop type:
Invalid prop `size` of value `20` supplied to `ForwardRef(SvgIcon)`, expected one of [null,null].

Заменил oneOf на oneOfType в тех местах, где использовались типы, а не примитивы

@JackUait JackUait changed the title fix(propTypes): oneOf -> oneOfType fix(propTypes): mistakes in propTypes Jun 12, 2022
@JackUait JackUait changed the title fix(propTypes): mistakes in propTypes fix: mistakes in propTypes Jun 12, 2022
@zhzz zhzz removed request for zhzz and khlutkova June 17, 2022 11:42
@zhzz zhzz requested a review from lossir June 28, 2022 11:50
@JackUait
Copy link
Contributor Author

Изменил название типа ComponentType на ReactNodePropTypes, а также уменьшил область влияния типа ReactNodePropTypes

lossir
lossir requested changes Jun 29, 2022
View reviewed changes
packages/react-ui/internal/Popup/Popup.tsx Outdated Show resolved Hide resolved
packages/react-ui/components/Textarea/TextareaCounter.tsx Outdated Show resolved Hide resolved
packages/react-ui/components/Sticky/Sticky.tsx Outdated Show resolved Hide resolved
packages/react-ui/lib/utils.ts Outdated Show resolved Hide resolved
@JackUait JackUait linked an issue Jun 29, 2022 that may be closed by this pull request
[DatePicker] Ошибка в консоли при фокусе инпута #2934
Closed
@JackUait JackUait mentioned this pull request Jun 29, 2022
Closed
@lossir lossir merged commit 74b1071 into master Jul 11, 2022
@lossir lossir deleted the fix/one-of-prop-types branch July 11, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lossir lossir lossir approved these changes

@HelenaIsh HelenaIsh HelenaIsh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DatePicker] Ошибка в консоли при фокусе инпута
3 participants
@JackUait @lossir @HelenaIsh