All tests broken with Go 1.14 beta1 #1096

eclipseo · 2020-02-04T19:31:42Z

Fedora Rawhide with Go 1.14 beta1

Testing    in: /builddir/build/BUILD/logrus-1.4.2/_build/src
         PATH: /builddir/build/BUILD/logrus-1.4.2/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/logrus-1.4.2/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/sirupsen/logrus/version=1.4.2 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/sirupsen/logrus
github.com/sirupsen/logrus
{"level":"info","logrus_error":"can not add field \"func\"","msg":"test","time":"2020-02-04T19:25:53Z"}
{"level":"info","msg":"test","str":"str","time":"2020-02-04T19:25:53Z"}
--- FAIL: TestReportCallerWhenConfigured (0.00s)
    logrus_test.go:42: 
        	Error Trace:	logrus_test.go:42
        	            				testutils.go:28
        	            				logrus_test.go:36
        	Error:      	Not equal: 
        	            	expected: "github.com/sirupsen/logrus_test.TestReportCallerWhenConfigured.func3"
        	            	actual  : "github.com/sirupsen/logrus.(*Entry).Info"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-github.com/sirupsen/logrus_test.TestReportCallerWhenConfigured.func3
        	            	+github.com/sirupsen/logrus.(*Entry).Info
        	Test:       	TestReportCallerWhenConfigured
--- FAIL: TestReportCallerHelperDirect (0.00s)
    logrus_test.go:96: 
        	Error Trace:	logrus_test.go:96
        	Error:      	Expect "github.com/sirupsen/logrus.(*Entry).Info" to match "github.com/.*/logrus_test.logSomething"
        	Test:       	TestReportCallerHelperDirect
--- FAIL: TestReportCallerHelperViaPointer (0.00s)
    logrus_test.go:106: 
        	Error Trace:	logrus_test.go:106
        	Error:      	Expect "github.com/sirupsen/logrus.(*Entry).Info" to match "github.com/.*/logrus_test.logSomething"
        	Test:       	TestReportCallerHelperViaPointer
--- FAIL: TestNestedLoggingReportsCorrectCaller (0.00s)
    logrus_test.go:381: 
        	Error Trace:	logrus_test.go:381
        	Error:      	Not equal: 
        	            	expected: "github.com/sirupsen/logrus_test.TestNestedLoggingReportsCorrectCaller"
        	            	actual  : "github.com/sirupsen/logrus.(*Entry).Info"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-github.com/sirupsen/logrus_test.TestNestedLoggingReportsCorrectCaller
        	            	+github.com/sirupsen/logrus.(*Entry).Info
        	Test:       	TestNestedLoggingReportsCorrectCaller
    logrus_test.go:385: 
        	Error Trace:	logrus_test.go:385
        	Error:      	Not equal: 
        	            	expected: "/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/logrus_test.go:373"
        	            	actual  : "/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/entry.go:285"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/logrus_test.go:373
        	            	+/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/entry.go:285
        	Test:       	TestNestedLoggingReportsCorrectCaller
    logrus_test.go:412: 
        	Error Trace:	logrus_test.go:412
        	Error:      	Not equal: 
        	            	expected: "github.com/sirupsen/logrus_test.TestNestedLoggingReportsCorrectCaller"
        	            	actual  : "github.com/sirupsen/logrus.(*Entry).Info"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-github.com/sirupsen/logrus_test.TestNestedLoggingReportsCorrectCaller
        	            	+github.com/sirupsen/logrus.(*Entry).Info
        	Test:       	TestNestedLoggingReportsCorrectCaller
    logrus_test.go:415: 
        	Error Trace:	logrus_test.go:415
        	Error:      	Not equal: 
        	            	expected: "/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/logrus_test.go:399"
        	            	actual  : "/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/entry.go:285"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/logrus_test.go:399
        	            	+/builddir/build/BUILD/logrus-1.4.2/_build/src/github.com/sirupsen/logrus/entry.go:285
        	Test:       	TestNestedLoggingReportsCorrectCaller
time="2020-02-04T19:25:53Z" level=info msg=info
time="2020-02-04T19:25:53Z" level=info msg=info context=clue wow=whale

INFO[0000] test                                          file=file func=func
time="2020-02-04T19:25:53Z" level=info msg=test file=file func=func
--- FAIL: ExampleCustomFormatter (0.00s)
got:
{"file":"logger.go","func":"Log","level":"info","msg":"example of custom format caller"}
want:
{"file":"example_custom_caller_test.go","func":"ExampleCustomFormatter","level":"info","msg":"example of custom format caller"}
FAIL
exit status 1
FAIL	github.com/sirupsen/logrus	0.780s

The text was updated successfully, but these errors were encountered:

dgsb · 2020-02-11T08:31:41Z

do we have a release date for go1.14 already ?
I suggest we wait for its release before fixing things

ergoz · 2020-02-26T10:36:19Z

go 1.14 is already released

tschaub · 2020-02-26T19:41:05Z

I assume this is related to the issue I'm seeing with go 1.14.

When I set logrus.SetReportCaller(true), I see fields like this logged:

{
  "file": "/Users/tschaub/go/pkg/mod/github.com/sirupsen/logrus@v1.4.2/entry.go:285",
  "func": "github.com/sirupsen/logrus.(*Entry).Info"
}

Perhaps @v1.4.2 is causing trouble with the getPackageName function?

Update: I see this reported in #1089 now.

tietang · 2020-03-01T15:13:12Z

I see the problem here：
github.com/sirupsen/logrus@v1.4.2/entry.go
line 167：function getCaller

func getCaller() *runtime.Frame {

	// cache this package's fully-qualified name
	callerInitOnce.Do(func() {
		pcs := make([]uintptr, 2)
		_ = runtime.Callers(0, pcs)
		**logrusPackage = getPackageName(runtime.FuncForPC(pcs[1]).Name())**

		// now that we have the cache, we can skip a minimum count of known-logrus functions
		// XXX this is dubious, the number of frames may vary
		minimumCallerDepth = knownLogrusFrames
	})

The variable ’logrusPackage‘’'v value is wrong.
I'm just going to rewrite it as： logrusPackage = "github.com/sirupsen/logrus" , It works.

In addition， it works In debug mode.

tietang · 2020-03-01T15:33:36Z

I see the problem here：

logrusPackage = getPackageName(runtime.FuncForPC(pcs[1]).Name())

Modified to：

logrusPackage = getPackageName(runtime.FuncForPC(pcs[0]).Name())

It works.

Go 1.14

heramerom · 2020-03-02T14:44:11Z

// getCaller retrieves the name of the first non-logrus calling function
func getCaller() *runtime.Frame {

	// cache this package's fully-qualified name
	callerInitOnce.Do(func() {
		pcs := make([]uintptr, maximumCallerDepth)
		_ = runtime.Callers(0, pcs)
		// dynamic get the package name and the minimum caller depth will has a mostly compatibility of go version
		for i := 0; i < maximumCallerDepth; i++ {
			funcName := runtime.FuncForPC(pcs[i]).Name()
			if strings.Contains(funcName, "getCaller")  {
				logrusPackage = getPackageName(funcName)
                                 break;
			}
		}
	})

cirelli94 · 2020-03-09T11:30:56Z

I tested @heramerom code and it works for me, with go version go1.14 linux/amd64.

However @heramom, I noticed you do no more:

minimumCallerDepth = knownLogrusFrames

Is it a desired behavior?

cirelli94 · 2020-03-09T14:04:43Z

@dgsb

do we have a release date for go1.14 already ?
I suggest we wait for its release before fixing things

Go 1.14 has been released! https://blog.golang.org/go1.14

pgbytes · 2020-03-09T14:22:19Z

I see we have the solution. Is someone working on a PR for this issue?

chibby0ne · 2020-03-09T14:39:22Z

@panshul007 I see you are primed and eager to help 😄. You are welcome to take a shot at it 🥇 👍

cirelli94 · 2020-03-09T16:13:31Z

@panshul007 @chibby0ne I did it! See #1108

I built and tried my project with my fork with both 1.13 and 1.14 with no issue.

zhsj · 2020-03-22T17:02:06Z

Sorry to bother. But can we have a new tag to address this issue?

markphelps · 2020-03-23T13:10:50Z

Done! https://github.com/sirupsen/logrus/releases/tag/v1.5.0

Thank you all!

markphelps added the bug label Feb 6, 2020

dgsb self-assigned this Feb 11, 2020

dgsb mentioned this issue Feb 25, 2020

Report Caller returns logrus files/functions with Go 1.14Beta1 #1089

Closed

dgsb mentioned this issue Feb 28, 2020

Log filename and line number #63

Closed

cirelli94 mentioned this issue Mar 9, 2020

Fix wrong caller #1108

Merged

jstaf mentioned this issue Mar 20, 2020

Logrus broken in Go 1.14 jstaf/onedriver#60

Closed

markphelps closed this as completed in #1108 Mar 22, 2020

This was referenced Jun 10, 2020

Logger is not configured correctly kubernetes-sigs/boskos#22

Closed

Update github.com/sirupsen/logrus to v1.6.0 kubernetes/test-infra#17908

Merged

This was referenced Aug 21, 2020

BCDA-3536 - Resolve issue with incorrect logging of func/filename CMSgov/bcda-app#537

Merged

BCDA-3536 - Resolve issue with incorrect logging of func/filename CMSgov/bcda-ssas-app#51

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All tests broken with Go 1.14 beta1 #1096

All tests broken with Go 1.14 beta1 #1096

eclipseo commented Feb 4, 2020

dgsb commented Feb 11, 2020 •

edited

ergoz commented Feb 26, 2020

tschaub commented Feb 26, 2020 •

edited

tietang commented Mar 1, 2020

tietang commented Mar 1, 2020

heramerom commented Mar 2, 2020 •

edited

cirelli94 commented Mar 9, 2020 •

edited

cirelli94 commented Mar 9, 2020 •

edited

pgbytes commented Mar 9, 2020

chibby0ne commented Mar 9, 2020

cirelli94 commented Mar 9, 2020 •

edited

zhsj commented Mar 22, 2020

markphelps commented Mar 23, 2020

All tests broken with Go 1.14 beta1 #1096

All tests broken with Go 1.14 beta1 #1096

Comments

eclipseo commented Feb 4, 2020

dgsb commented Feb 11, 2020 • edited

ergoz commented Feb 26, 2020

tschaub commented Feb 26, 2020 • edited

tietang commented Mar 1, 2020

tietang commented Mar 1, 2020

heramerom commented Mar 2, 2020 • edited

cirelli94 commented Mar 9, 2020 • edited

cirelli94 commented Mar 9, 2020 • edited

pgbytes commented Mar 9, 2020

chibby0ne commented Mar 9, 2020

cirelli94 commented Mar 9, 2020 • edited

zhsj commented Mar 22, 2020

markphelps commented Mar 23, 2020

dgsb commented Feb 11, 2020 •

edited

tschaub commented Feb 26, 2020 •

edited

heramerom commented Mar 2, 2020 •

edited

cirelli94 commented Mar 9, 2020 •

edited

cirelli94 commented Mar 9, 2020 •

edited

cirelli94 commented Mar 9, 2020 •

edited