BCDA-3536 - Resolve issue with incorrect logging of func/filename #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrang1263
requested review from
jeffcorpuz,
msnook,
orenfromberg and
PatKelsh
jeffcorpuz
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BCDA-3536
We were seeing the incorrect logging name/file when using logrus#SetReportCaller(true).
This was related to an issue with our version of logrus and Go 1.14.
More details here: sirupsen/logrus#1096
Resolved here: sirupsen/logrus#1108
Change Details
v1.6.0) which includes the PR referenced above.Security Implications
Newer version of logrus introduced in this PR.
Acceptance Validation
Verified locally that logging information is fixed after updating to
v1.6.0