Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger is not configured correctly #22

Closed
ixdy opened this issue Jun 5, 2020 · 1 comment · Fixed by #24
Closed

Logger is not configured correctly #22

ixdy opened this issue Jun 5, 2020 · 1 comment · Fixed by #24
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@ixdy
Copy link
Contributor

ixdy commented Jun 5, 2020

Looking at logs from a recent boskos build (from this repo) reveals that some things are not configured appropriately:

boskos:

{"component":"unset","file":"/go/pkg/mod/github.com/sirupsen/logrus@v1.4.2/entry.go:314","func":"github.com/sirupsen/logrus.(*Entry).Logf","handler":"handleUpdate","level":"info","msg":"From 10.44.2.234:42282","time":"2020-06-05T23:01:09Z"}

cleaner:

{"component":"unset","file":"/go/pkg/mod/github.com/sirupsen/logrus@v1.4.2/logger.go:192","func":"github.com/sirupsen/logrus.(*Logger).Log","level":"info","msg":"Cleaner started","time":"2020-06-05T22:47:27Z"}

etc.

The component is unset because we aren't setting the variables in k8s.io/test-infra/prow/version.
We can fairly easily add linker flags for this, though it'll require a bit of work in the Makefile (or maybe we'll just want to write a wrapper script).

I'm not sure why we're getting useless file and function annotations, though.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 5, 2020
@ixdy
Copy link
Contributor Author

ixdy commented Jun 10, 2020

The caller information being incorrect is sirupsen/logrus#1096. We'll need to update our logrus dependency.

@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants