Remove ignore option for isGitIgnored and isGitIgnoredSync

[fisker]

Ref #223 (comment)

[sindresorhus]

While we're removing the ignore option for isGitIgnored, I think globby should still ignore these paths by default in the main globby methods.

[fisker]

These were ONLY used when glob .gitignore file, changing globby() to ignore files in these directories is a new breaking change to the globby() function, it out scope of this PR.

And if we decide to ignore them by default, but how to unignore them?

[sindresorhus]

These were ONLY used when glob .gitignore file

Yes, that's what I'm talking about. Only for .gitignore files. It doesn't make sense to look for .gitignore files inside node_modules and doing so would create a big slowdown.

For reference, here's the original commit that added the ignores: ba08350

[fisker]

Ah, you are right, misunderstood.

[fisker]

As I tested, when use **/node_modules/ and **/node_modules/**/*, fast-glob will read those directories, but when use **/node_modules , fast-glob won't read them.

[fisker]

Answering this question #224 (comment)

[fisker]

I still have one thing want to do before you can release, the expandDirectories requires file access, though I already reduced the tasks, we still expanding ignore repeatedly, we can expand them in 0~2 steps, one for the common ignore, one for the negative patterns.

[fisker]

I'm going to give up for this #225 (comment).

I have tried, the logic became more complex, but didn't see much performance improvement, maybe because the file access is fast enough. Adding this logic also only benefit cases with multiple discontinuous negative patterns, it's not very common.

[sindresorhus]

Thanks for all the work you have been doing. I did a new release: https://github.com/sindresorhus/globby/releases/tag/v13.0.0