New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update globby and replace secretlintignore logics #592

Open

1 of 4 tasks

azu opened this issue Aug 5, 2023 · 0 comments

Open

1 of 4 tasks

Update globby and replace secretlintignore logics #592

azu opened this issue Aug 5, 2023 · 0 comments

Labels

Status: PR Welcome Status: Proposal

Member

azu commented Aug 5, 2023 •

edited

Remove ignore option for isGitIgnored and isGitIgnoredSync (sindresorhus/globby#225) sindresorhus/globby@2e43cc4
This option never worked correctly.
Release v13.0.0 · sindresorhus/globby

current implementation uses ignore option. We need to update globby and use ignoreFiles.

TODO

Add missing test case
Update globby
Move DEFAULT_IGNORE_PATTERNS to options.ignore from ignore
- https://github.com/sindresorhus/globby#options
Use ignoreFiles option as needed

Originally posted by @azu in #589 (comment)

The text was updated successfully, but these errors were encountered:

azu added Status: Proposal Status: PR Welcome labels

azu mentioned this issue

.secretlintignore does not work in Windows #589

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment