.secretlintignore does not work in Windows

[risu729]

What version of secretlint are you using?

7.0.3

What did you do? Please include the actual steps causing the issue.

1. Write a secret in test.txt
2. Add it to .secretlintignore

test.txt

3. Run pnpm secretlint "**/*" --maskSecrets

What did you expect to happen?
No errors were thrown.

What actually happened? Please include the actual, raw output from secretlint.

test.txt has not been ignored.

  secretlint input: [ '**/*' ] +0ms
  secretlint flags: {
  secretlint   maskSecrets: true,
  secretlint   init: false,
  secretlint   format: 'stylish',
  secretlint   secretlintignore: '.secretlintignore',
  secretlint   color: true,
  secretlint   terminalLink: true,
  secretlint   profile: false,
  secretlint   cwd: 'C:\\Users\\taku\\Documents\\GitHub\\reponame',
  secretlint   debug: false
  secretlint } +5ms
  secretlint searchFiles ignore baseDir: , normalizeIgnoreFilePath: C:\Users\taku\Documents\GitHub\reponame\.secretlintignore +0ms
  secretlint ignored: [ '/Users/taku/Documents/GitHub/reponame/test.txt' ] +2ms
  secretlint search patterns: [ '**/*' ] +1ms
  secretlint search ignore patterns: [ '**/.git/**', '**/node_modules/**', '**/.secretlintrc/**', '**/.secretlintrc.{json,yaml,yml,js}/**', '**/.secretlintignore*/**', '/Users/taku/Documents/GitHub/reponame/test.txt' ] +0ms

C:/Users/taku/Documents/GitHub/reponame/test.txt
  1:0  error  [GITHUB_TOKEN] found GitHub Token(*****************************): ****************************************  @secretlint/secretlint-rule-preset-recommend > @secretlint/secretlint-rule-github

✖ 1 problem (1 error, 0 warnings)

I will create a PR to fix this issue soon.

[azu]

Can you paste your .secretlintignore?

[risu729]

Updated the original comment!

[azu]

Thanks.

Probably, current implement has an issue on Windows, I think.

secretlint/packages/secretlint/src/search.ts

Line 30 in 00e689e

export const searchFiles = async (patterns: string[], options: SearchFilesOptions) => {

However, globby has supported ignoreFiles option at recent.
Switing current implemention to ignoreFiles option that may resolve this issue.

• sindresorhus/globby: User-friendly glob matching
  • Release v13.1.0 · sindresorhus/globby

[azu]

Remove ignore option for isGitIgnored and isGitIgnoredSync (sindresorhus/globby#225) sindresorhus/globby@2e43cc4
This option never worked correctly.
Release v13.0.0 · sindresorhus/globby

current implementation uses ignore option. We need to update globby and use ignoreFiles.

TODO

• Add missing test case
• Update globby
• Move DEFAULT_IGNORE_PATTERNS to options.ignore from ignore
  • https://github.com/sindresorhus/globby#options
• Use ignoreFiles option as needed

[risu729]

Thank you for your information. It seems better than my solution!
Can I close my PR?

[azu]

@risu729 Thanks for PR!
No problem. I will merge your PR soon.

I'll file my suggestion as another issue.

[azu]

This will be fixed in v7.0.4

Thanks for PR!

[azu]

• Update globby and replace secretlintignore logics #592

I created a separate Issue for the remaining tasks.