Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow border to be optional. #88

Merged
merged 6 commits into from May 6, 2023

Conversation

Caesarovich
Copy link
Collaborator

Fixes #84

Fix not being able to specify empty strings in borderStyle options.

@Caesarovich
Copy link
Collaborator Author

@sindresorhus I propose this to be 7.0.3

@sindresorhus
Copy link
Owner

You have to update the readme and types too.

@Caesarovich
Copy link
Collaborator Author

@sindresorhus I'm not really sure what you mean by that. Empty strings are still of type string for TS so it does not change anything regarding the types from my point of view. Please let me know your thoughts.

@sindresorhus
Copy link
Owner

Your pull request title does not match the pull request description. Optional is not the same as empty string.

@sindresorhus
Copy link
Owner

This is not actually fixing what was asked in the issue. The issue asked for the borderStyle option to be optional.

We could either allow borderStyle to accept undefined or define a new border style called 'none'.

@Caesarovich
Copy link
Collaborator Author

@sindresorhus I'm more into the 'none' option. I'll work on it asap

@Caesarovich
Copy link
Collaborator Author

@sindresorhus That needs investigation, I cannot replicate the test errors. I'm not sure what it is about.

@sindresorhus sindresorhus merged commit 1f9c8e2 into sindresorhus:main May 6, 2023
0 of 3 checks passed
@sindresorhus
Copy link
Owner

I will publish an update tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow border to be optional.
2 participants