New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes implementation of `borderStyle` "none" #89

Merged

sindresorhus merged 3 commits into sindresorhus:main from roydukkey:issue84/pr88-fixup

Jul 4, 2023

Contributor

roydukkey commented May 10, 2023 •

edited

#88 doesn't completely implement the feature requested in #84

Fix width when borderStyle is "none"
Remove prepended blank line when:
1. borderStyle is "none",
2. title is undefined,
3. and both padding and margin are 0
Remove appended blank line when:
1. borderStyle is "none",
2. height is not greater than the intrinsic maximum height of the content,
3. and both padding and margin are 0


          Fix width when borderStyle is “none”

f2a6d84

roydukkey marked this pull request as ready for review

May 10, 2023 03:55

sindresorhus requested a review from Caesarovich

June 20, 2023 11:37

Caesarovich approved these changes

View reviewed changes

roydukkey added 2 commits

June 29, 2023 20:23


          Fix blank lines when borderStyle is “none”

9feca34


          Fix spelling

f67797c

sindresorhus merged commit ef5c987 into sindresorhus:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment