Rack 3 support

[dentarg]

Adds support for Rack 3, drops support for Rack 2.

Close #1797

• make sinatra test handles params without a value pass
• address various rack deprecations
• address Rack::Handler is deprecated and replaced by Rackup::Handler
• make rack latest job work
• restore continue-on-error in test workflow
• use rackup 2.x https://rubygems.org/gems/rackup
• use rack-session 2.x https://rubygems.org/gems/rack-session

See the individual commits for various details.

Old comment from Dec, 2022

There's one failing test left to address (besides async tests that I have disabled for now, that area is being discussed a bit in #1853): EDIT: behaviour changed in Rack 3: rack/rack#1989

sinatra/test/routing_test.rb

Lines 314 to 323 in 9b6ba81

	it "handles params without a value" do
	mock_app {
	get '/' do
	assert_nil params.fetch('foo')
	"Given: #{params.keys.sort.join(',')}"
	end
	}
	get '/?foo'
	assert_equal 'Given: foo', body
	end

Opening as draft until we have addressed that – and also until I've taken this for a spin with a real app – something for next year! Happy New Year Sinatra users 🥳

---

This work was sponsored by 84codes (CloudAMQP, CloudKarafka, ElephantSQL, CloudMQTT)

[dentarg]

There's one failing test left to address

EDIT: behaviour changed in Rack 3: rack/rack#1989

---

Some links about it:

• d8c1839
• Avoid TypeError when params contain a key without a value on Ruby < 2.4 #1517
• avoid multiple errors even if params contains special values #1526

Re: async/streaming, https://github.com/dentarg/sinatra/actions/runs/3807969308/jobs/6478153396 is a test run before I reverted 4210184 if anyone are curious

[jkowens]

Thank you @dentarg and 84codes 🤗

[ioquatix]

It would be great to have a 3.x release that supports Rack 3+

[dentarg]

@ioquatix you mean a release that supports both Rack 2 and Rack 3?

[ioquatix]

Yeah,

You can use rack-session and rackup gems if those are dependencies, the v1 release of those gems is for Rack v2 and the v2 release of those gems is for Rack 3+.

[dentarg]

We'll see. Sounds like (a lot?) more effort.

[ioquatix]

Maybe check this for ideas about how to be compatible with both Rack 2 and Rack 3. The biggest one is dealing with headers. If you don't want to force people to use lower case headers, you can use Rack::Headers.

rails/rails#46594 (comment)

[ioquatix]

Looking good.

[dentarg]

@ioquatix I wanted to make the tests pass on "rack head" (main branch) too, but rack/rack@1bd0f15 makes a few tests fail (for sinatra and sinatra-contrib). Not sure how I should handle that. I suspect that change in Rack will be considered a breaking change? Will it be included in Rack 3.1?

[ioquatix]

It will be included in Rack 3.1 - it's not breaking in the sense that it's recommended to use that mime type. The previous mime type is now considered legacy/obsolete, but browsers would handle them both as meaning the same thing. Your test should accept both.

[dentarg]

Not sure this fail is related to the changes here, maybe more tweaks are needed? Re: #1887 (comment)

1) Failure:
IntegrationAsyncTest#test_with_puma_streams_async_0 [/home/runner/work/sinatra/sinatra/test/integration_async_test.rb:[21](https://github.com/sinatra/sinatra/actions/runs/4336782825/jobs/7572318485#step:5:22)]:
--- expected
+++ actual
@@ -1 +1 @@
-["hi!", "hello"]
+["hi!", "hello", "hi!", "hello"]

Locally, it works for me to run the sinatra tests on truffle ruby:

docker run --rm -it -v $(pwd):/app -w /app ghcr.io/graalvm/truffleruby:debian-22.3.1 bash
apt-get update && apt-get install --yes \
          git \
          pandoc \
          nodejs \
          pkg-config \
          libxml2-dev \
          libxslt-dev \
          libyaml-dev
bundle
bundle exec rake

[dentarg]

Not sure this fail is related to the changes here

The re-run passed: https://github.com/sinatra/sinatra/actions/runs/4336782825/jobs/7572670654

[zzak]

Nice work!! Thank you so much 🍡

[zerbinidamata]

Hey all, is this close to being released?

[dentarg]

Depends on what's "close"

I think there's a discussion that needs to happen about dropping Rack 2 support

Also, I will be busy the coming the weeks

[dentarg]

@zerbinidamata have you tested this in a real world application? if not, can you?

[dentarg]

Re: my comment from December:

There's one failing test left to address
EDIT: behaviour changed in Rack 3: rack/rack#1989

sinatra/test/routing_test.rb

Lines 314 to 323 in 9b6ba81

	it "handles params without a value" do
	mock_app {
	get '/' do
	assert_nil params.fetch('foo')
	"Given: #{params.keys.sort.join(',')}"
	end
	}
	get '/?foo'
	assert_equal 'Given: foo', body
	end

Just saw rails/rails#47652 and rack/rack#2052 (apparently released with Rack v3.0.6)

[ioquatix]

Wow, nice work!