Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paradise lost, also, stability (GETTING STARTED does NOT) #2003

Closed
costa opened this issue Mar 11, 2024 · 4 comments · Fixed by #2009
Closed

paradise lost, also, stability (GETTING STARTED does NOT) #2003

costa opened this issue Mar 11, 2024 · 4 comments · Fixed by #2009

Comments

@costa
Copy link

costa commented Mar 11, 2024

Try the very essence of sinatra — running a simple web app with minimal effort:
docker run --rm ruby bash -ec 'gem install sinatra; gem install puma; ruby -e "require %[sinatra]; get(%[/]){%[Hello stability!]}"'
and FAIL miserably — sinatra is too advanced for such nonsense now:
Sinatra could not start, the "rackup" gem was not found!

Thank you for maintainers for maintaining — and advancing— this complex beast of a system.

@dentarg
Copy link
Member

dentarg commented Mar 11, 2024

Change gem install sinatra to gem install rackup sinatra, does it work then?

@costa
Copy link
Author

costa commented Mar 11, 2024

Wow, I haven't thought about that, but I'm happy and honoured to contribute to development of the component I've simply used for many, many years (with zero issues), before it apparently got too advanced for my primitive usage, so... Thank you for your maintenance and here's what I think you've asked for:

docker run --rm ruby bash -ec 'gem install sinatra rackup; ruby -e "require %[sinatra]; get(%[/]){%[Hello?]}"'

results in

== Sinatra (v4.0.0) has taken the stage on 4567 for development with backup from WEBrick

Yay! Let me know if you'd like me to test anything else.

p.s. I hope you can excuse my annoying comments — I'm sure you have a perfectly good explanation of how it is someone else's problem, rack's probably — but I've been with Ruby community for a long time and I'm disappointed about the encroaching betrayal of the main platform's principle; and here, it is not really that hard to keep those programmers happy: we have just 3 gems that matter here: Rails, Sinatra and Rack, so I just can't see a reasonable difficulty of sync'ing stuff up and not letting the basic functionality to fall in gaps — in the name of some marginal advancements. TL;DR rackup must be a dependency.

@dentarg
Copy link
Member

dentarg commented Mar 27, 2024

We had consensus around not making rackup a hard dependency in the Rack 3 pull request, see the discussion from #1857 (comment)

I've made #2009 to update the README to reflect this, thanks for bringing attention to it

dentarg added a commit that referenced this issue Mar 27, 2024
@rubyFeedback
Copy link

costa wrote:

we have just 3 gems that matter here: Rails, Sinatra and Rack

Sinatra and Rack I can see, but Rails?

As for rackup, I believe it is not a dependency and I don't use it myself. IMO it should only be a dependence for code that depends on it, but sinatra works fine without rackup as far as I understand (I don't use .ru files for instance but I use sinatra just fine; I hate the .ru extension and want to avoid it totally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants