Falcon integration #1794
Merged
Falcon integration #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we still testing Line 1444 in fb6f2da |
|
@ioquatix I was just about to ask about that 😅 It doesn't look like there is a test for that, so yeah that would still be an issue. Could something similar be done with Falcon, or should Sinatra have an update for SIGINT handling? |
|
I could reproduce the issue but the fix will be in falcon, not here, so it's safe to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to #1677 which can be closed after merging this, all tests passing locally. LMK if any further changes are needed.