New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puma is not used as the default server if thin
is available
#1883
Labels
Comments
ghiculescu
changed the title
Puma is not necessarily the default server
Puma is not used as the default server if Feb 21, 2023
thin
is available
I do think we should make Puma the default. |
I'm in favour of both having puma as the default and dropping thin, not sure if both of them warrants a new major version? Right now, Thin would have to be dropped if we release a version of Sinatra that only supports Rack 3. |
Actually, #1794, made Falcon to be preferred over Puma too 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The readme says:
This suggests that if puma is installed, it will always be used as the server. But that's not true. To demonstrate:
Output:
If you uninstall
thin
, you get:A fix would be either to change the docs, or to move this line to the bottom of the servers list so that puma is considered first. I'm happy to do a PR for either, but not sure which behaviour is intended.
The text was updated successfully, but these errors were encountered: