Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puma is not used as the default server if thin is available #1883

Closed
ghiculescu opened this issue Feb 21, 2023 · 4 comments · Fixed by #1924
Closed

Puma is not used as the default server if thin is available #1883

ghiculescu opened this issue Feb 21, 2023 · 4 comments · Fixed by #1924
Labels

Comments

@ghiculescu
Copy link

The readme says:

It is recommended to also run gem install puma, which Sinatra will pick up if available.

This suggests that if puma is installed, it will always be used as the server. But that's not true. To demonstrate:

gem uninstall puma sinatra thin # reset things
gem install puma sinatra thin
ruby myapp.rb

Output:

== Sinatra (v3.0.4) has taken the stage on 4567 for development with backup from Thin

If you uninstall thin, you get:

== Sinatra (v3.0.4) has taken the stage on 4567 for development with backup from Puma

A fix would be either to change the docs, or to move this line to the bottom of the servers list so that puma is considered first. I'm happy to do a PR for either, but not sure which behaviour is intended.

@ghiculescu ghiculescu changed the title Puma is not necessarily the default server Puma is not used as the default server if thin is available Feb 21, 2023
@dentarg
Copy link
Member

dentarg commented Feb 21, 2023

So Thin was dropped in #1627 but then added back in 342758a without the docs being updated.

@jkowens
Copy link
Member

jkowens commented Feb 21, 2023

I do think we should make Puma the default.

@dentarg
Copy link
Member

dentarg commented Feb 21, 2023

I'm in favour of both having puma as the default and dropping thin, not sure if both of them warrants a new major version? Right now, Thin would have to be dropped if we release a version of Sinatra that only supports Rack 3.

@dentarg
Copy link
Member

dentarg commented May 15, 2023

Actually, #1794, made Falcon to be preferred over Puma too 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants