Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puma to 4.3.6 #1533

Merged
merged 2 commits into from Nov 19, 2020
Merged

Update puma to 4.3.6 #1533

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adfc85e
Update puma to 4.3.6
Nov 17, 2020
6715b95
Merge branch 'master' into puma-4.3.6
rsanheim Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Expand Up @@ -307,7 +307,7 @@ GEM
pry-rails (0.3.9)
pry (>= 0.10.4)
public_suffix (4.0.5)
puma (4.3.5)
puma (4.3.6)
nio4r (~> 2.0)
rack (2.2.3)
rack-attack (6.3.1)
Expand Down
25 changes: 0 additions & 25 deletions README.md
View file
Open in desktop
Expand Up @@ -75,31 +75,6 @@ rake yarn:install
rails db:setup
```

##### Issues with MacOS Catalina and Puma

When running `bin/setup` on MacOS Catalina, you may encounter issues installing the `puma` gem related to compiler upgrades Apple issued.

If you see errors like this:

```
compiling puma_http11.c
puma_http11.c:203:22: error: implicitly declaring library function 'isspace' with type 'int (int)' [-Werror,-Wimplicit-function-declaration]
while (vlen > 0 && isspace(value[vlen - 1])) vlen--;
^
puma_http11.c:203:22: note: include the header <ctype.h> or explicitly provide a declaration for 'isspace'
1 error generated.
make: *** [puma_http11.o] Error 1
make failed, exit code 2
```

To fix, install `puma` with this command:

```
gem install puma:4.3.5 -- --with-cflags="-Wno-error=implicit-function-declaration"
```

Now re-run `bin/setup` to continue installing everything else.

#### Developing with the Android app

To run [simple-android](https://github.com/simpledotorg/simple-android/) app with the server running locally, you can
Expand Down