Update puma to 4.3.6 #1533
Update puma to 4.3.6 #1533
Conversation
There was a bug on Puma version 4.3.5, causing it to fail when trying to compile. It was fixed with [#2304]. This commit updates Gemfile.lock and removes the now redundant explanations on readme. [#2304]: puma/puma#2304
|
Hi @ogirginc, thanks a ton for the submission! We'll try and find sometime this week to check if nothing breaks because of the Heads-up, the team is on a break in the last week of November, so if we don't get a chance to try this, we might only get to it by the first week of December. Cheers! |
|
Hi @kitallis. Thanks for the heads up and no worries at all! Technically, it should not break anything according to the changelog, which has only 2 bug fixes:
Have a nice & safe break! |
|
I just hit the puma issue again while bootstrapping a new M1 mac, so I'm going to take a look at merging this... |
|
side note: I had to temporarily disable some statue check requirements, as I don't believe our workflows run Standardrb checks or the "CI push" check from forked contributions. |
When I pushed #1532, it did actually worked. However, Github showed me "This branch is out-of-date with the base branch" warning and I pressed the "Update Branch" button which created a merge commit. To prevent merge commit, I have pulled master, rebased and pushed but this time CI did not run. 🤷 Just thought, I should share as it might help somehow. |
Because
There was a bug on Puma version 4.3.5, causing it to fail when trying to
compile. It was fixed with #2304.
This addresses
This commit updates Gemfile.lock and removes the now redundant
explanations on readme.