FIX Handle admin_email array config #10258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
force-pushed
the
pulls/4.9/email-array
branch
from
e2d5471
to
7b5e025
Compare
| // https://docs.silverstripe.org/en/4/developer_guides/email/#administrator-emails | ||
| $adminEmail = $this->config()->get('admin_email'); | ||
| if (is_array($adminEmail) && count($adminEmail) > 0) { | ||
| $defaultFrom = array_keys($adminEmail)[0]; |
There was a problem hiding this comment.
Suggested change
| $defaultFrom = array_keys($adminEmail)[0]; | |
| $defaultFrom = array_key_first($adminEmail); |
There was a problem hiding this comment.
Reverted, PHP 7.1 (which 4.9 supports) doesn't have the array_key_first, it's new with php 7.3.0
There was a problem hiding this comment.
Ah, ok, I thought we dropped support below 7.4 now but didn't realise 4.9 still has it. All good.
There was a problem hiding this comment.
Yeah 4.10 was when older PHP support was dropped.
michalkleiner
approved these changes
Mar 9, 2022
emteknetnz
force-pushed
the
pulls/4.9/email-array
branch
from
7b5e025
to
5c02ea3
Compare
emteknetnz
force-pushed
the
pulls/4.9/email-array
branch
from
5c02ea3
to
204b39b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10257