Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email::getDefaultFrom() needs to account for array config #10257

Closed
5 tasks done
emteknetnz opened this issue Mar 9, 2022 · 1 comment
Closed
5 tasks done

Email::getDefaultFrom() needs to account for array config #10257

emteknetnz opened this issue Mar 9, 2022 · 1 comment
Assignees
@emteknetnz
Labels
impact/critical type/bug

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 9, 2022 •
edited

admin_email can be either a string or an array
https://docs.silverstripe.org/en/4/developer_guides/email/#administrator-emails

This recent PR only accounted for the string config, but not the array config

Currently if array config is encountered, trying to reset a members password will throw a hard error

ACs

  • Handle array config
  • Tag a new version of 4.9
  • Tag a new version of 4.10
  • Ensure the extension hook $this->extend('updateDefaultFrom', $defaultFrom); only appears in the 4 branch

PRs
@emteknetnz emteknetnz self-assigned this Mar 9, 2022
@emteknetnz emteknetnz mentioned this issue Mar 9, 2022
Merged
@emteknetnz
Copy link
Member Author

Linked PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
impact/critical type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emteknetnz