Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Fulcio username identity in SAN #2291

Merged
merged 3 commits into from Sep 30, 2022

Commits on Sep 28, 2022

  1. Add support for Fulcio username identity in SAN

    We have changed the format of the username identity to not look
    like an email, and so we also needed to change which SAN the username
    was set in. Now using OtherName, I've added some custom unmarshalling
    to extract the OtherName SAN, because Go doesn't support this SAN type.
    
    Note in verify.go, I had to handle when the extension was critical.
    Since Go doesn't handle the extension, but it must be marked critical
    according to RFC5280, the cert will fail verification. We can simply
    remove the extension from the list of unhandled extensions before
    verifying.
    
    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    haydentherapper committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    547ee87 View commit details
    Browse the repository at this point in the history
  2. fix lint

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    haydentherapper committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    dd7eb8e View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. address comments

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    haydentherapper committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1c3bf13 View commit details
    Browse the repository at this point in the history