Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Fulcio username identity in SAN #2291

Merged
merged 3 commits into from Sep 30, 2022
Merged

Add support for Fulcio username identity in SAN #2291

merged 3 commits into from Sep 30, 2022

Conversation

haydentherapper
Copy link
Contributor

We have changed the format of the username identity to not look like an email, and so we also needed to change which SAN the username was set in. Now using OtherName, I've added some custom unmarshalling to extract the OtherName SAN, because Go doesn't support this SAN type.

Note in verify.go, I had to handle when the extension was critical. Since Go doesn't handle the extension, but it must be marked critical according to RFC5280, the cert will fail verification. We can simply remove the extension from the list of unhandled extensions before verifying.

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Release Note

Added support for new Fulcio username identity format

Documentation

@haydentherapper
Add support for Fulcio username identity in SAN
547ee87 
We have changed the format of the username identity to not look
like an email, and so we also needed to change which SAN the username
was set in. Now using OtherName, I've added some custom unmarshalling
to extract the OtherName SAN, because Go doesn't support this SAN type.

Note in verify.go, I had to handle when the extension was critical.
Since Go doesn't handle the extension, but it must be marked critical
according to RFC5280, the cert will fail verification. We can simply
remove the extension from the list of unhandled extensions before
verifying.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

fyi @woodruffw, I'm not sure if the Python crypto library will have the same issue of not supporting less well known SAN types.

@haydentherapper
fix lint
dd7eb8e 
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
znewman01
znewman01 reviewed Sep 29, 2022
View reviewed changes
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mostly nitpicks 🙂

BTW tests in certextensions_test.go look really great, thanks for the excellent comments

pkg/cosign/certextensions.go Outdated Show resolved Hide resolved
pkg/cosign/certextensions.go Outdated Show resolved Hide resolved
pkg/cosign/certextensions.go Outdated Show resolved Hide resolved
pkg/cosign/certextensions.go Outdated Show resolved Hide resolved
pkg/cosign/certextensions.go Outdated Show resolved Hide resolved
pkg/cosign/certextensions.go Show resolved Hide resolved
pkg/cosign/verify.go Outdated Show resolved Hide resolved
@haydentherapper
address comments
1c3bf13 
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
znewman01
znewman01 approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haydentherapper
Copy link
Contributor Author

This is good to merge!

@dlorenc dlorenc merged commit 983c364 into sigstore:main Sep 30, 2022
@github-actions github-actions bot added this to the v1.13.0 milestone Sep 30, 2022
jeff-mccoy pushed a commit to defenseunicorns/zarf that referenced this pull request Oct 7, 2022
@renovate
Update module github.com/sigstore/cosign to v1.13.0 (#863)
6379653 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/sigstore/cosign](https://togithub.com/sigstore/cosign) |
require | minor | `v1.12.1` -> `v1.13.0` |

---

### Release Notes

<details>
<summary>sigstore/cosign</summary>

###
[`v1.13.0`](https://togithub.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v1130)

[Compare
Source](https://togithub.com/sigstore/cosign/compare/v1.12.1...v1.13.0)

> # Highlights
>
> - For users who have deployed a private instance of Fulcio release
v0.6.x and issue certificates with the Username identity, you will need
to upgrade to use this version."

#### Enhancements

- Add support for Fulcio username identity in SAN
([sigstore/cosign#2291)
- Data race in FetchSignaturesForReference
([sigstore/cosign#2283)
- Check error on chain verification failure
([sigstore/cosign#2284)
- feat: improve the verification message
([sigstore/cosign#2268)
- feat: use stdin as an input for predicate
([sigstore/cosign#2269)

#### Bug Fixes

- fix: make tlog entry lookups for online verification shard-aware
([sigstore/cosign#2297)
- Fix: Create a static copy of signatures as part of verification.
([sigstore/cosign#2287)
- Fix: Remove an extra registry request from verification path.
([sigstore/cosign#2285)
- fix pivtool generate key touch policy
([sigstore/cosign#2282)

#### Others

- use scaffolding 0.4.8 for tests.
([sigstore/cosign#2280)

#### Contributors

-   Asra Ali ([@&#8203;asraa](https://togithub.com/asraa))
- Batuhan Apaydın
([@&#8203;developer-guy](https://togithub.com/developer-guy))
- Carlos Tadeu Panato Junior
([@&#8203;cpanato](https://togithub.com/cpanato))
- Hayden Blauzvern
([@&#8203;haydentherapper](https://togithub.com/haydentherapper))
-   Matt Moore ([@&#8203;mattmoor](https://togithub.com/mattmoor))
-   Ross Tannenbaum ([@&#8203;RTann](https://togithub.com/RTann))
-   Ville Aikas ([@&#8203;vaikas](https://togithub.com/vaikas))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIyMi4zIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@haydentherapper haydentherapper deleted the othername branch January 10, 2023 23:34
Noxsios pushed a commit to defenseunicorns/zarf that referenced this pull request Mar 8, 2023
@renovate
Update module github.com/sigstore/cosign to v1.13.0 (#863)
2dec3c4 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/sigstore/cosign](https://togithub.com/sigstore/cosign) |
require | minor | `v1.12.1` -> `v1.13.0` |

---

### Release Notes

<details>
<summary>sigstore/cosign</summary>

###
[`v1.13.0`](https://togithub.com/sigstore/cosign/blob/HEAD/CHANGELOG.md#v1130)

[Compare
Source](https://togithub.com/sigstore/cosign/compare/v1.12.1...v1.13.0)

> # Highlights
>
> - For users who have deployed a private instance of Fulcio release
v0.6.x and issue certificates with the Username identity, you will need
to upgrade to use this version."

#### Enhancements

- Add support for Fulcio username identity in SAN
([sigstore/cosign#2291)
- Data race in FetchSignaturesForReference
([sigstore/cosign#2283)
- Check error on chain verification failure
([sigstore/cosign#2284)
- feat: improve the verification message
([sigstore/cosign#2268)
- feat: use stdin as an input for predicate
([sigstore/cosign#2269)

#### Bug Fixes

- fix: make tlog entry lookups for online verification shard-aware
([sigstore/cosign#2297)
- Fix: Create a static copy of signatures as part of verification.
([sigstore/cosign#2287)
- Fix: Remove an extra registry request from verification path.
([sigstore/cosign#2285)
- fix pivtool generate key touch policy
([sigstore/cosign#2282)

#### Others

- use scaffolding 0.4.8 for tests.
([sigstore/cosign#2280)

#### Contributors

-   Asra Ali ([@&#8203;asraa](https://togithub.com/asraa))
- Batuhan Apaydın
([@&#8203;developer-guy](https://togithub.com/developer-guy))
- Carlos Tadeu Panato Junior
([@&#8203;cpanato](https://togithub.com/cpanato))
- Hayden Blauzvern
([@&#8203;haydentherapper](https://togithub.com/haydentherapper))
-   Matt Moore ([@&#8203;mattmoor](https://togithub.com/mattmoor))
-   Ross Tannenbaum ([@&#8203;RTann](https://togithub.com/RTann))
-   Ville Aikas ([@&#8203;vaikas](https://togithub.com/vaikas))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click
this checkbox.

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIyMi4zIn0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znewman01 znewman01 znewman01 approved these changes

@dlorenc dlorenc dlorenc approved these changes

@bobcallaway bobcallaway Awaiting requested review from bobcallaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haydentherapper @znewman01 @dlorenc