New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate Alibaba Cloud Container Registry cred helper #2008
Merged
dlorenc
merged 7 commits into
sigstore:main
from
mozillazg:support-alibaba-acr-keychain
Aug 29, 2022
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d1ac93c
feat: integrate Alibaba Cloud Container Registry cred helper
mozillazg b81dbc3
update codegen
mozillazg 2327e84
Merge remote-tracking branch 'upstream/main' into support-alibaba-acr…
mozillazg 3771279
Merge remote-tracking branch 'upstream/main' into support-alibaba-acr…
mozillazg e4fbac0
upgrade dependencies
mozillazg fbd3145
Merge remote-tracking branch 'upstream/main' into support-alibaba-acr…
mozillazg cb656bc
Use `io.Discard` instead of `ioutil.Discard`
mozillazg File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really your responsibility, but I'd like to document this behavior a little better in general.
Along with that, the
--k8s-keychainflag that controls this is somewhat poorly named -- it always has been, but it's especially confusing if we add a cred helper that isn't included in the standard k8s cred helpers, and it'll only get worse if we add more in the future.Again, this isn't really your fault, and I don't think we need to change anything in this PR, just noting it for whomever decides to take this on in the future (likely me).