feat: integrate Alibaba Cloud Container Registry cred helper #2008
Conversation
mozillazg
force-pushed
the
support-alibaba-acr-keychain
branch
from
85b58a1
to
1024cf4
Compare
Integrate a new keychain to support Alibaba Cloud Container Registry when run with the `--k8s-keychain` flag. Resolves: sigstore#2007 Signed-off-by: mozillazg <mozillazg101@gmail.com>
mozillazg
force-pushed
the
support-alibaba-acr-keychain
branch
from
1024cf4
to
d1ac93c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2008 +/- ##
==========================================
+ Coverage 26.03% 26.69% +0.65%
==========================================
Files 131 131
Lines 7689 7690 +1
==========================================
+ Hits 2002 2053 +51
+ Misses 5445 5376 -69
- Partials 242 261 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: mozillazg <mozillazg101@gmail.com>
|
@imjasonh Anything I can help with to get this PR approved? |
cmd/cosign/cli/options/registry.go
Outdated
| @@ -85,6 +86,7 @@ func (o *RegistryOptions) GetRegistryClientOpts(ctx context.Context) []remote.Op | |||
| google.Keychain, | |||
| authn.NewKeychainFromHelper(ecr.NewECRHelper(ecr.WithLogger(ioutil.Discard))), | |||
| authn.NewKeychainFromHelper(credhelper.NewACRCredentialsHelper()), | |||
| authn.NewKeychainFromHelper(alibabaacr.NewACRHelper().WithLoggerOut(ioutil.Discard)), | |||
There was a problem hiding this comment.
It's not really your responsibility, but I'd like to document this behavior a little better in general.
Along with that, the --k8s-keychain flag that controls this is somewhat poorly named -- it always has been, but it's especially confusing if we add a cred helper that isn't included in the standard k8s cred helpers, and it'll only get worse if we add more in the future.
Again, this isn't really your fault, and I don't think we need to change anything in this PR, just noting it for whomever decides to take this on in the future (likely me).
…-keychain Signed-off-by: mozillazg <mozillazg101@gmail.com>
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Signed-off-by: mozillazg <mozillazg101@gmail.com>
@dlorenc ping~ |
Signed-off-by: mozillazg <mozillazg101@gmail.com>
Summary
Integrate a new keychain to support Alibaba Cloud Container Registry.
Ticket Link
Fixes #2007
Release Note