Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fulcio signer to take in KeyOpts (take 2) #1818

Merged
merged 2 commits into from Apr 30, 2022

Commits on Apr 22, 2022

  1. Refactor fulcio signer to take in KeyOpts.

    This commit should not have change in behavior. It changes the fulcio signer
    to take in the KeyOpts struct instead of passing individual parameters through,
    as well as moves common code dependent on the values to the same place.
    
    The motivation behind this change is to make it easier to add new options without
    needing to plumb through another param to the already long list.
    
    To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the
    options package.
    
    Signed-off-by: Billy Lynch <billy@chainguard.dev>
    wlynch committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    0d0e5b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Re-add OIDC providers to sign command.

    Signed-off-by: Billy Lynch <billy@chainguard.dev>
    wlynch committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    75f0496 View commit details
    Browse the repository at this point in the history