Refactor fulcio signer to take in KeyOpts (take 2) #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should not have change in behavior. It changes the fulcio signer to take in the KeyOpts struct instead of passing individual parameters through, as well as moves common code dependent on the values to the same place. The motivation behind this change is to make it easier to add new options without needing to plumb through another param to the already long list. To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the options package. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Signed-off-by: Billy Lynch <billy@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1818 +/- ##
==========================================
+ Coverage 31.46% 32.84% +1.38%
==========================================
Files 144 147 +3
Lines 8893 9349 +456
==========================================
+ Hits 2798 3071 +273
- Misses 5758 5922 +164
- Partials 337 356 +19
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 30, 2022
|
Nice fix! |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Refactor fulcio signer to take in KeyOpts. This commit should not have change in behavior. It changes the fulcio signer to take in the KeyOpts struct instead of passing individual parameters through, as well as moves common code dependent on the values to the same place. The motivation behind this change is to make it easier to add new options without needing to plumb through another param to the already long list. To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the options package. Signed-off-by: Billy Lynch <billy@chainguard.dev> * Re-add OIDC providers to sign command. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a roll-forward of #1788 with the provider fix (goimports accidentally removed
pkg/providers/allwhich removed the OIDC providers in the first commit) to fixthe e2e tests.
This commit should not have change in behavior. It changes the fulcio signer
to take in the KeyOpts struct instead of passing individual parameters through,
as well as moves common code dependent on the values to the same place.
The motivation behind this change is to make it easier to add new options without
needing to plumb through another param to the already long list.
To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the
options package.
Ticket Link
Part of #1785 (wanted to make this change first to make adding the option easier)
Release Note