Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the KMS integration imports into the binary entrypoints #1744

Merged
merged 2 commits into from Apr 12, 2022
Merged

Move the KMS integration imports into the binary entrypoints #1744

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44d32ff
Move the KMS integration imports into the binary entrypoints
mattmoor Apr 12, 2022
2ffb7ac
Remove the fake import
mattmoor Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/cosign/main.go
View file
Open in desktop
Expand Up @@ -21,6 +21,12 @@ import (
"strings"

"github.com/sigstore/cosign/cmd/cosign/cli"

// Register the provider-specific plugins
_ "github.com/sigstore/sigstore/pkg/signature/kms/aws"
_ "github.com/sigstore/sigstore/pkg/signature/kms/azure"
_ "github.com/sigstore/sigstore/pkg/signature/kms/gcp"
_ "github.com/sigstore/sigstore/pkg/signature/kms/hashivault"
)

func main() {
Expand Down
8 changes: 8 additions & 0 deletions cmd/cosign/policy_webhook/main.go
View file
Open in desktop
Expand Up @@ -34,6 +34,14 @@ import (

"github.com/sigstore/cosign/pkg/apis/cosigned/v1alpha1"
"github.com/sigstore/cosign/pkg/reconciler/clusterimagepolicy"

// Register the provider-specific plugins
_ "github.com/sigstore/sigstore/pkg/signature/kms/aws"
_ "github.com/sigstore/sigstore/pkg/signature/kms/azure"
_ "github.com/sigstore/sigstore/pkg/signature/kms/gcp"
_ "github.com/sigstore/sigstore/pkg/signature/kms/hashivault"
// TODO(mattmoor): Not sure why this is in the final binary...
// _ "github.com/sigstore/sigstore/pkg/signature/kms/fake"
mattmoor marked this conversation as resolved.
Show resolved Hide resolved
)

func main() {
Expand Down
7 changes: 0 additions & 7 deletions pkg/reconciler/clusterimagepolicy/clusterimagepolicy.go
View file
Open in desktop
Expand Up @@ -44,13 +44,6 @@ import (
sigs "github.com/sigstore/cosign/pkg/signature"
"github.com/sigstore/sigstore/pkg/signature/kms"
signatureoptions "github.com/sigstore/sigstore/pkg/signature/options"

// Register the provider-specific plugins
_ "github.com/sigstore/sigstore/pkg/signature/kms/aws"
_ "github.com/sigstore/sigstore/pkg/signature/kms/azure"
_ "github.com/sigstore/sigstore/pkg/signature/kms/fake"
_ "github.com/sigstore/sigstore/pkg/signature/kms/gcp"
_ "github.com/sigstore/sigstore/pkg/signature/kms/hashivault"
)

// Reconciler implements clusterimagepolicyreconciler.Interface for
Expand Down
6 changes: 0 additions & 6 deletions pkg/signature/keys.go
View file
Open in desktop
Expand Up @@ -35,12 +35,6 @@ import (
"github.com/sigstore/sigstore/pkg/signature"

"github.com/sigstore/sigstore/pkg/signature/kms"

// Register the provider-specific plugins
_ "github.com/sigstore/sigstore/pkg/signature/kms/aws"
_ "github.com/sigstore/sigstore/pkg/signature/kms/azure"
_ "github.com/sigstore/sigstore/pkg/signature/kms/gcp"
_ "github.com/sigstore/sigstore/pkg/signature/kms/hashivault"
)

var (
Expand Down