Move the KMS integration imports into the binary entrypoints #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: sigstore/sigstore#384 Related: sigstore/sigstore#386 Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
|
cc @imjasonh |
Codecov Report
@@ Coverage Diff @@
## main #1744 +/- ##
=======================================
Coverage 29.48% 29.48%
=======================================
Files 141 141
Lines 8505 8505
=======================================
Hits 2508 2508
Misses 5726 5726
Partials 271 271
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 12, 2022
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
2 tasks
9 tasks
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…e#1744) * Move the KMS integration imports into the binary entrypoints Related: sigstore/sigstore#384 Related: sigstore/sigstore#386 Signed-off-by: Matt Moore <mattmoor@chainguard.dev> * Remove the fake import Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
Related: sigstore/sigstore#384
Related: sigstore/sigstore#386
Release Note