Add private to Web UI Cache-Control to prevent request collapsing #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the followup! |
jonhyman
pushed a commit
to braze-inc/sidekiq
that referenced
this pull request
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #4966, I realized it's also important to add
privateto the Cache-Control header as well to prevent request collapsing. Even withno-store, Fastly (and I assume other places) can still collapse requests.Note that this is only important if the Web UI is behind some form of authentication, since it provides the possibility of sending authenticated data to non-authenticated users under very specific circumstances.
This matches the example here that fastly shows to prevent downstream caching + request collapsing.