Add private to Sidekiq Web UI Cache-Control to prevent request collap…

…sing (sidekiq#4967)
braze-inc · Sep 16, 2021 · 31d9330 · 31d9330
1 parent b5c85f3
commit 31d9330
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/sidekiq/web/action.rb b/lib/sidekiq/web/action.rb
@@ -68,7 +68,7 @@ def render(engine, content, options = {})
     end
 
     def json(payload)
-      [200, {"Content-Type" => "application/json", "Cache-Control" => "no-store"}, [Sidekiq.dump_json(payload)]]
+      [200, {"Content-Type" => "application/json", "Cache-Control" => "private, no-store"}, [Sidekiq.dump_json(payload)]]
     end
 
     def initialize(env, block)

diff --git a/lib/sidekiq/web/application.rb b/lib/sidekiq/web/application.rb
@@ -314,7 +314,7 @@ def call(env)
         # rendered content goes here
         headers = {
           "Content-Type" => "text/html",
-          "Cache-Control" => "no-store",
+          "Cache-Control" => "private, no-store",
           "Content-Language" => action.locale,
           "Content-Security-Policy" => CSP_HEADER
         }