Change cache-control to private #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in sidekiq/sidekiq#5936 the public cache control could leak information when used with CloudFront or other CDNs. It was decided to change the cache setting in Sidekiq web's static assets to private. This changes the gem's cache-control settings to match the recently released Sidekiq's.
|
@marcelolx - I'll probably merge this myself sometime Friday evening or Saturday (US East time) unless someone thinks this is a horrible idea. |
|
I am good with it if that solves the problem, I had in mind to try to remove this entirely because of what Mike mentioned here #432 (comment), so we wouldn't have to worry about it anymore But if that isn't as simple as doing this, we can move forward with it and revisit it |
|
Let's go with this for now (to stop the... "bleeding"? for those who would be affected) and revist doing what Mike mentioned later then. 👍 |
|
Sounds good to me, created an issue for it so I don't forget about it 🙈 #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in sidekiq/sidekiq#5936 the public cache control could leak information when used with CloudFront or other CDNs. It was decided to change the cache setting in Sidekiq web's static assets to private.
This changes the gem's cache-control settings to match the recently released Sidekiq's.