Skip to content

Commit

Permalink
Change cache-control to private (#446)
Browse files Browse the repository at this point in the history
As mentioned in sidekiq/sidekiq#5936 the public cache control could leak information when used with CloudFront or other CDNs. It was decided to change the cache setting in Sidekiq web's static assets to private.

This changes the gem's cache-control settings to match the recently released Sidekiq's.
  • Loading branch information
t27duck committed Jun 15, 2023
1 parent a36871c commit cc9eb57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/sidekiq-scheduler/extensions/web.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
Sidekiq::Web.use Rack::Static, urls: ['/stylesheets-scheduler'],
root: ASSETS_PATH,
cascade: true,
header_rules: [[:all, { 'cache-control' => 'public, max-age=86400' }]]
header_rules: [[:all, { 'cache-control' => 'private, max-age=86400' }]]

0 comments on commit cc9eb57

Please sign in to comment.