Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Normalize globby path for cli build command #44

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(cli): Normalize globby path for cli build command #44

merged 1 commit into from
Oct 30, 2023

Conversation

bhuynhdev
Copy link
Contributor

@bhuynhdev bhuynhdev commented Oct 29, 2023

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

I used the existing test suite and did not make any new tests

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #41

Description

As discussed in #41, the jsx-email's CLI build command use globby to search for file names to read, build, and write to. However, per sindresorhus/globby#179, on Windows system, Globby won't work as Windows path contains backslashes but Globby only wants path with forward slashes.
Therefore, a normalizePath function (inspired by rollup) was used to normalize the path so it would work on both Windows and UNIX systems

@shellscape shellscape changed the title Normalize globby path for cli build command fix(cli): Normalize globby path for cli build command Oct 30, 2023
@shellscape
Copy link
Owner

Thanks for getting this in. Will merge as soon as CI is done.

In other news, pnpm has prioritized a fix for the issue that is preventing us from running the Windows CI workflow here. Hoping that we get a fix soon and can enable better Windows support in development.

@shellscape shellscape merged commit 601e3ae into shellscape:main Oct 30, 2023
5 of 8 checks passed
@shellscape
Copy link
Owner

thanks!

@bhuynhdev bhuynhdev deleted the globby-fix branch October 31, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build on windows
2 participants