-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not build on windows #41
Comments
Sorry, but that's not true. If you're not willing to help demonstrate the issue, I'm afraid there's nothing we can do to help. None of the current maintainers are Windows users, so I'd recommend using WSL for the time being. |
Hi, just want to let the team know that I am experiencing the same issue in Windows. The Development server works fine, but when I run email build ./templates
Found 0 files:
Starting build...
Build complete. Files written to: ... I understand that none of the current maintainers are Windows users, so I am just communicating here to raise some awareness to the issue. Will try to make a PR if possible |
A PR would be great. Appreciate the additional info. This issue is more than likely the result of the older version of globby that we're using at the moment. I still don't know what exact fix the OP was referencing, but it probably has to do with path normalization. |
I dug around for a bit, and per this issue sindresorhus/globby#179, it seems that the glob pattern must only contain forward slashes, but the Therefore, I replaced I am trying to make a PR but the steps in the CONTRIBUTING.md doc seems to not work on both my Windows and my WSL. I have Nodejs 18.18.2, and have ran Error: project_graph::unknown_project
× No project has been configured with the name or alias jsx-email. |
Thanks for the heads up, I'll get the doc updated. In place of |
Also here's rollup's path normalization routine that's very proven, for reference https://github.com/rollup/plugins/blob/master/packages/pluginutils/src/normalizePath.ts#L5 |
Attempted to setup a workflow matrix so we could use github actions to try and debug, but unfortunately there's an issue between |
Oh it was my bad, as I didn't name my folder Never mind, I solved this by running Successfully created #44 after confirming that |
Thanks for working through that. We'll get that doc updated 👍 |
@jsxp-email/cli
Version?: 1.1.0npm create jsx-email
, no need for reproduction.Expected Behavior
Build works on Windows
Actual Behavior
It doesn't
Additional Information
Can't create PR now
Build command uses
globby
, which returns empty arrays on windows paths. You should useglobby([slash(join(temp, "*.js")])
everywhere in CLI.Thanks
The text was updated successfully, but these errors were encountered: